From mboxrd@z Thu Jan  1 00:00:00 1970
From: Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API
Date: Thu, 21 May 2009 11:52:05 -0400
Message-ID: <4A1578A5.7090608@redhat.com>
References: <20090520205758.25003.44632.stgit@localhost.localdomain>	 <20090520205805.25003.71314.stgit@localhost.localdomain> <40e92d5b0905201501i1548621xe1ee63aa88129a0@mail.gmail.com> <4A1488A2.30706@redhat.com> <4A14EA86.2060609@zytor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: =?UTF-8?B?UHJ6ZW15c8WCYXcgUGF3ZcWCY3p5aw==?=  <przemyslaw@pawelczyk.it>,         Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,         lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>,         DLE <dle-develop@lists.sourceforge.net>,         Jim Keniston <jkenisto@us.ibm.com>,         Ananth N Mavinakayanahalli <ananth@in.ibm.com>,         Frederic Weisbecker <fweisbec@gmail.com>,         Andi Kleen <ak@linux.intel.com>,         Vegard Nossum <vegard.nossum@gmail.com>, Avi Kivity <avi@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Return-path: <systemtap-return-12415-gls-systemtap=m.gmane.org@sourceware.org>
In-Reply-To: <4A14EA86.2060609@zytor.com>
List-Unsubscribe: <mailto:systemtap-unsubscribe-gls-systemtap=m.gmane.org@sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
List-Id: kvm.vger.kernel.org

H. Peter Anvin wrote:
> Masami Hiramatsu wrote:
>>> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
>>>
>>> which is obviously wrong.
>> Oops, right. Anyway, there is no reason that we make it
>> executable because it's always called from Makefile.
>> So, I think just removing that line is better way.
>>
> 
> I suggest leaving in a #!/bin/awk line just for documentation's sake,
> though.

OK, I'd leave that, and change usage line to use awk command
instead of run the script directly.

Thank you!

> 
> 	-hpa
> 

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com