From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] kvm-kmod: x86: Drop duplicate external-module-compat objects Date: Sat, 23 May 2009 13:55:29 +0200 Message-ID: <4A17E431.1010105@web.de> References: <4A170535.3090007@web.de> <20090523013659.GH20823@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9A107601146DEB698B7CB211" Cc: Avi Kivity , kvm-devel To: Chris Wright Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:51766 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbZEWLz3 (ORCPT ); Sat, 23 May 2009 07:55:29 -0400 In-Reply-To: <20090523013659.GH20823@sequoia.sous-sol.org> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9A107601146DEB698B7CB211 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Chris Wright wrote: > * Jan Kiszka (jan.kiszka@web.de) wrote: >> This redundancy breaks subtly when building against recent OpenSUSE >> kernels. >=20 > What breaks? When building external-module-compat.c, linux/scripts/basic/hash somehow gets called with a multi-word modname. It complains via its usage, and gcc then tries to compile files it derives from that output: gcc -Wp,-MD,/data/kvm-kmod/x86/../.external-module-compat.o.d -nostdin= c -isystem /usr/lib64/gcc/x86_64-suse-linux/4.3/include -D__KERNEL__ -I/d= ata/kvm-kmod/include -Iinclude -Iinclude2 -I/lib/modules/2.6.27.21-0.1= -default/source/include -Iarch/x86/include -I/data/kvm-kmod/include-comp= at -include include/linux/autoconf.h -include /data/kvm-kmod/x= 86/external-module-compat.h -I/data/kvm-kmod/x86 -Wall -Wundef -Wstrict= -prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-impli= cit-function-declaration -Os -m64 -mtune=3Dgeneric -mno-red-zone -mcmodel= =3Dkernel -funit-at-a-time -maccumulate-outgoing-args -DCONFIG_AS_CFI=3D1= -DCONFIG_AS_CFI_SIGNAL_FRAME=3D1 -pipe -Wno-sign-compare -mno-sse -mno-m= mx -mno-sse2 -mno-3dnow -I/usr/src/linux-2.6.27.21-0.1/include/asm-x86/ma= ch-default -Iinclude/asm-x86/mach-default -fno-stack-protector -fomit-fra= me-pointer -fasynchronous-unwind-tables -g -Wdeclaration-after-statement = -Wno-pointer-sign -fwrapv -DMODULE -D"KBUILD_STR( s)=3D#s" -D"KBUILD_BASENAME=3DKBUILD_STR(external_module_compat)" -D"DEB= UG_HASH=3DUsage: ./scripts/basic/hash " -D"DEBUG_HASH2= =3DUsage: ./scripts/basic/hash " -c -o /data/kvm-kmod/= x86/../.tmp_external-module-compat.o /data/kvm-kmod/x86/../external-modul= e-compat.c gcc: : Datei oder Verzeichnis nicht gefunden gcc: : Datei oder Verzeichnis nicht gefunden gcc: : Datei oder Verzeichnis nicht gefunden gcc: : Datei oder Verzeichnis nicht gefunden Jan --------------enig9A107601146DEB698B7CB211 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoX5DEACgkQniDOoMHTA+mXYgCdFLHQz8RECPwzv+ypFx/5vSLT MVsAni08q2/Y6fi4KGWar2iAuHWyGpyV =Y/Ix -----END PGP SIGNATURE----- --------------enig9A107601146DEB698B7CB211--