From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dor Laor Subject: Re: [PATCH 2/2] Advertise X2APIC support. Date: Sun, 24 May 2009 09:46:44 +0300 Message-ID: <4A18ED54.4070504@redhat.com> References: <1242927475-6140-1-git-send-email-gleb@redhat.com> <1242927475-6140-3-git-send-email-gleb@redhat.com> Reply-To: dlaor@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42756 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbZEXGqT (ORCPT ); Sun, 24 May 2009 02:46:19 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4O6kKxq009532 for ; Sun, 24 May 2009 02:46:20 -0400 In-Reply-To: <1242927475-6140-3-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > --- > target-i386/cpu.h | 1 + > target-i386/helper.c | 5 +++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index f054af1..29d730e 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -252,6 +252,7 @@ > #define MSR_IA32_APICBASE 0x1b > #define MSR_IA32_APICBASE_BSP (1<<8) > #define MSR_IA32_APICBASE_ENABLE (1<<11) > +#define MSR_IA32_APICBASE_EXTD (1<<10) > #define MSR_IA32_APICBASE_BASE (0xfffff<<12) > > #define MSR_MTRRcap 0xfe > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 23efcf4..170c3f7 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -148,7 +148,7 @@ static x86_def_t x86_defs[] = { > CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | > /* this feature is needed for Solaris and isn't fully implemented */ > CPUID_PSE36, > - .ext_features = CPUID_EXT_SSE3, > + .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_X2APIC, > Why not first test if the feature exists in the kernel? > .ext2_features = (PPRO_FEATURES & 0x0183F3FF) | > CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX | > CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT, > @@ -199,7 +199,8 @@ static x86_def_t x86_defs[] = { > /* The original CPU also implements these ext features: > CPUID_EXT_DTES64, CPUID_EXT_DSCPL, CPUID_EXT_VMX, CPUID_EXT_EST, > CPUID_EXT_TM2, CPUID_EXT_CX16, CPUID_EXT_XTPR, CPUID_EXT_PDCM */ > - .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_SSSE3, > + .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_SSSE3 | > + CPUID_EXT_X2APIC, > .ext2_features = CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX, > /* Missing: .ext3_features = CPUID_EXT3_LAHF_LM */ > .xlevel = 0x80000008, >