From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [KVM_Autotest] Fix to allow for "=" in the "value" of a config parameter. Date: Sun, 24 May 2009 15:14:47 +0300 Message-ID: <4A193A37.6030305@redhat.com> References: <825827984.224981242990310267.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Huff , kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34757 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611AbZEXMOr (ORCPT ); Sun, 24 May 2009 08:14:47 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4OCEnOs015104 for ; Sun, 24 May 2009 08:14:49 -0400 In-Reply-To: <825827984.224981242990310267.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Michael Goldish wrote: > This makes sense, thanks. > > One thing though -- I don't know if it's even worth mentioning -- we always try to put a single space after a comma (I think the Python style guide recommends that but I'm not sure). Generally we try to follow the guide (http://www.python.org/dev/peps/pep-0008/) and as far as I know Autotest follows it too. > Strongly agree, Python's syntax allows us to write very pretty code, it makes sense to preserve this. -- error compiling committee.c: too many arguments to function