From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][KVM-AUTOTEST] Check exit status of custom install script and fail if script failed. Date: Sun, 24 May 2009 17:48:40 +0300 Message-ID: <4A195E48.5080300@redhat.com> References: <1242851931-8492-1-git-send-email-mburns@redhat.com> <1242851931-8492-2-git-send-email-mburns@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, dhuff@redhat.com, ulublin@redhat.com To: Mike Burns Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47122 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753282AbZEXOsk (ORCPT ); Sun, 24 May 2009 10:48:40 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4OEmhl7017098 for ; Sun, 24 May 2009 10:48:43 -0400 In-Reply-To: <1242851931-8492-2-git-send-email-mburns@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mike Burns wrote: > Signed-off-by: Mike Burns > --- > client/tests/kvm_runtest_2/kvm_install.py | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/client/tests/kvm_runtest_2/kvm_install.py b/client/tests/kvm_runtest_2/kvm_install.py > index ebd8b7d..392ef0c 100755 > --- a/client/tests/kvm_runtest_2/kvm_install.py > +++ b/client/tests/kvm_runtest_2/kvm_install.py > @@ -90,7 +90,12 @@ def run_kvm_install(test, params, env): > kvm_log.info("Adding KVM_INSTALL_%s to Environment" % (k)) > os.putenv("KVM_INSTALL_%s" % (k), str(params[k])) > kvm_log.info("Running " + script + " to install kvm") > - os.system("cd %s; %s" % (test.bindir, script)) > + install_result = os.system("cd %s; %s" % (test.bindir, script)) > + if os.WEXITSTATUS(install_result) != 0: > + message = "Custom Script encountered an error" > + kvm_log.error(message) > + raise error.TestError, message > + > How about a helper that does os.system() (or rather, commands.getstatusoutput()) and throws an exception on failure? I imagine it could be used in many places. Oh and "Custom script encountered an error" is unfriendly. Mention the command line and the actual output. -- error compiling committee.c: too many arguments to function