From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH -v3] KVM: MCE: Add MCE support to KVM Date: Mon, 25 May 2009 19:40:38 +0200 Message-ID: <4A1AD816.1060702@siemens.com> References: <1242031695.8213.17.camel@yhuang-dev.sh.intel.com> <4A105DE2.8090200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Huang Ying , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen To: Avi Kivity Return-path: Received: from gecko.sbs.de ([194.138.37.40]:21521 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbZEYRlB (ORCPT ); Mon, 25 May 2009 13:41:01 -0400 In-Reply-To: <4A105DE2.8090200@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Huang Ying wrote: >> The related MSRs are emulated. MCE capability is exported via >> extension KVM_CAP_MCE and ioctl KVM_X86_GET_MCE_CAP_SUPPORTED. A new >> vcpu ioctl command KVM_X86_SETUP_MCE is used to setup MCE emulation >> such as the mcg_cap. MCE is injected via vcpu ioctl command >> KVM_X86_SET_MCE. Extended machine-check state (MCG_EXT_P) and CMCI are >> not implemented. >> >> > > Applied, thanks. > This patch breaks kvm build for 32-bit hosts. Is the KVM MCE interface completely or only partially limited to x86-64, ie. can I completely #ifdef it away on 32-bit hosts (including KVM_CAP_MCE) or is this more complicated? Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux