From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH RFC v2 4/4] Use macro to iterate over vcpus.
Date: Tue, 26 May 2009 11:56:18 +0300 [thread overview]
Message-ID: <4A1BAEB2.9090901@redhat.com> (raw)
In-Reply-To: <20090526083759.GN3948@redhat.com>
Gleb Natapov wrote:
>
>>> +
>>> +#define kvm_for_each_vcpu(idx, vcpup, kvm) \
>>> + for (idx = 0, vcpup = kvm_get_vcpu(kvm, idx); \
>>> + idx < atomic_read(&kvm->online_vcpus) && vcpup; \
>>> + vcpup = kvm_get_vcpu(kvm, ++idx))
>>> +
>>>
>>>
>> This will stop when reaching the first empty vcpu slot, while current
>> code skips over empty slots. Please preserve existing behaviour.
>>
>>
> That's the idea, there is no more empty slots in vcpus array. Otherwise
> we always need to iterate over MAX_CPUS and not online_vcpus.
>
Yes, of course.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-05-26 8:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 15:50 [PATCH RFC v2 0/4] decouple vcpu index from apic id Gleb Natapov
2009-05-25 15:50 ` [PATCH RFC v2 1/4] Introduce kvm_vcpu_is_bsp() function Gleb Natapov
2009-05-25 20:46 ` Marcelo Tosatti
2009-05-26 6:12 ` Gleb Natapov
2009-05-25 15:50 ` [PATCH RFC v2 2/4] Use pointer to vcpu instead of vcpu_id in timer code Gleb Natapov
2009-05-26 8:30 ` Avi Kivity
2009-05-26 8:52 ` Gleb Natapov
2009-05-25 15:50 ` [PATCH RFC v2 3/4] Break dependency between vcpu index in vcpus array and vcpu_id Gleb Natapov
2009-05-26 8:34 ` Avi Kivity
2009-05-26 8:55 ` Gleb Natapov
2009-05-26 8:57 ` Avi Kivity
2009-05-25 15:50 ` [PATCH RFC v2 4/4] Use macro to iterate over vcpus Gleb Natapov
2009-05-26 8:18 ` Avi Kivity
2009-05-26 8:37 ` Gleb Natapov
2009-05-26 8:56 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1BAEB2.9090901@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).