From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Add qemu_send_raw() to vlan. Date: Tue, 26 May 2009 14:15:37 +0300 Message-ID: <4A1BCF59.5030901@redhat.com> References: <20090526100302.GS3948@redhat.com> <1243334080.19124.16.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36450 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbZEZLPh (ORCPT ); Tue, 26 May 2009 07:15:37 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4QBFdOx009094 for ; Tue, 26 May 2009 07:15:39 -0400 In-Reply-To: <1243334080.19124.16.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote: > >> It gets packet without virtio header and adds it if needed. Allows to >> inject packets to vlan from outside. To send gracious arp for instance. >> > > Acked-by: Mark McLoughlin > > This isn't ideal, but neither is the current VNET_HDR stuff and it does > fix a genuine bug. At least it's not changing existing APIs and makes it > clear this is a problem we also need to solve when merging VNET_HDR > support upstream. > > (Gleb - it might be worth patching qemu.git to use qemu_send_packet() in > announce_self(), that will reduce the delta between the trees) > > Okay. Bug Gleb, please add a signoff. -- error compiling committee.c: too many arguments to function