From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Downsize max support MSI-X entry to 256 Date: Tue, 26 May 2009 14:41:41 +0300 Message-ID: <4A1BD575.3000904@redhat.com> References: <1242885013-32735-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53224 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbZEZLlm (ORCPT ); Tue, 26 May 2009 07:41:42 -0400 In-Reply-To: <1242885013-32735-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > We only trap one page for MSI-X entry now, so it's 4k/(128/8) = 256 entries at > most. > > Applied, thanks. > > -#define KVM_MAX_MSIX_PER_DEV 512 > +#define KVM_MAX_MSIX_PER_DEV 256 > struct kvm_assigned_msix_entry { > __u32 assigned_dev_id; > __u32 gsi; > It's really unfortunate that this is a compile-time constant instead of run-time discoverable. -- error compiling committee.c: too many arguments to function