From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 8/8] kvm-kmod: x86: Add MCE compat defines Date: Tue, 26 May 2009 15:08:30 +0300 Message-ID: <4A1BDBBE.6060106@redhat.com> References: <20090526115251.3362.54734.stgit@mchn012c.ww002.siemens.net> <20090526115252.3362.67189.stgit@mchn012c.ww002.siemens.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45092 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbZEZMIc (ORCPT ); Tue, 26 May 2009 08:08:32 -0400 In-Reply-To: <20090526115252.3362.67189.stgit@mchn012c.ww002.siemens.net> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Signed-off-by: Jan Kiszka > --- > > x86/external-module-compat.h | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h > index c33eb2e..cc984ab 100644 > --- a/x86/external-module-compat.h > +++ b/x86/external-module-compat.h > @@ -540,3 +540,11 @@ struct mtrr_state_type { > #ifndef CONFIG_HAVE_KVM_IRQCHIP > #define CONFIG_HAVE_KVM_IRQCHIP 1 > #endif > + > +#ifndef MCG_CTL_P > +#define MCG_CTL_P (1ULL<<8) > +#define MCG_STATUS_MCIP (1ULL<<2) > +#define MCI_STATUS_VAL (1ULL<<63) > +#define MCI_STATUS_OVER (1ULL<<62) > +#define MCI_STATUS_UC (1ULL<<61) > +#endif > > This breaks on recent kernels (redefinition), so I removed it. Suggest adding an include-compat/asm-x86/asm/mce.h and including that. -- error compiling committee.c: too many arguments to function