From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 7/8] kvm-kmod: x86: Add MSR_IA32_TSC compat define Date: Tue, 26 May 2009 14:36:11 +0200 Message-ID: <4A1BE23B.7040803@siemens.com> References: <20090526115251.3362.54734.stgit@mchn012c.ww002.siemens.net> <20090526115252.3362.58985.stgit@mchn012c.ww002.siemens.net> <1243340947.12303.7.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Jaswinder Singh Rajput Return-path: Received: from gecko.sbs.de ([194.138.37.40]:21844 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbZEZMiw (ORCPT ); Tue, 26 May 2009 08:38:52 -0400 In-Reply-To: <1243340947.12303.7.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Jaswinder Singh Rajput wrote: > Hello Jan, > > On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote: >> Signed-off-by: Jan Kiszka >> --- >> >> x86/external-module-compat.h | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h >> index 3e6fc11..c33eb2e 100644 >> --- a/x86/external-module-compat.h >> +++ b/x86/external-module-compat.h >> @@ -497,6 +497,10 @@ struct kvm_desc_ptr { >> #define FEATURE_CONTROL_VMXON_ENABLED (1<<2) >> #endif >> >> +#ifndef MSR_IA32_TSC >> +#define MSR_IA32_TSC 0x00000010 >> +#endif >> + > > AFAIK, MSR_IA32_TSC is defined in include/asm/msr-index.h which is > available for kernel as well as user space and it is available from long > time. msr-index.h is "fairly" new (keep in mind all the x86 unifications and renaming of msr.h to msr-index.h). > > Can you please point me in which case MSR_IA32_TSC is not visible. I'm about to loose overview of all those issues I ran into with older kernels (still more to fix, sigh), but I think to remember this was a 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include this. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux