Re: [PATCH 8/8] kvm-kmod: x86: Add MCE compat defines

[Avi Kivity <avi@redhat.com>]

Jan Kiszka wrote:
>>> +
>>> +#ifndef MCG_CTL_P
>>> +#define MCG_CTL_P        (1ULL<<8)
>>> +#define MCG_STATUS_MCIP  (1ULL<<2)
>>> +#define MCI_STATUS_VAL   (1ULL<<63)
>>> +#define MCI_STATUS_OVER  (1ULL<<62)
>>> +#define MCI_STATUS_UC    (1ULL<<61)
>>> +#endif
>>>
>>>   
>>>       
>> This breaks on recent kernels (redefinition), so I removed it.  Suggest
>> adding an include-compat/asm-x86/asm/mce.h and including that.
>>     
>
> Non-empty mce.h will not work (but a patch to add an empty one was
> missing from my queue) - new kernel have that file, but with improper
> definitions for 32-bit. But what was that recent kernel and what was the
> precise problem? 

2.6.27, those defines were redefined (by the subsequent include of mce.h)

> ATM I could only imagine that the block above is
> included before original mce.h, right? Then adding an explicit include
> here should cure the problem.
>   

Yes.

-- 
error compiling committee.c: too many arguments to function