From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 8/8] kvm-kmod: x86: Add MCE compat defines Date: Tue, 26 May 2009 15:59:18 +0300 Message-ID: <4A1BE7A6.6030108@redhat.com> References: <20090526115251.3362.54734.stgit@mchn012c.ww002.siemens.net> <20090526115252.3362.67189.stgit@mchn012c.ww002.siemens.net> <4A1BDBBE.6060106@redhat.com> <4A1BE3F2.9010400@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34965 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755408AbZEZM7U (ORCPT ); Tue, 26 May 2009 08:59:20 -0400 In-Reply-To: <4A1BE3F2.9010400@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: >>> + >>> +#ifndef MCG_CTL_P >>> +#define MCG_CTL_P (1ULL<<8) >>> +#define MCG_STATUS_MCIP (1ULL<<2) >>> +#define MCI_STATUS_VAL (1ULL<<63) >>> +#define MCI_STATUS_OVER (1ULL<<62) >>> +#define MCI_STATUS_UC (1ULL<<61) >>> +#endif >>> >>> >>> >> This breaks on recent kernels (redefinition), so I removed it. Suggest >> adding an include-compat/asm-x86/asm/mce.h and including that. >> > > Non-empty mce.h will not work (but a patch to add an empty one was > missing from my queue) - new kernel have that file, but with improper > definitions for 32-bit. But what was that recent kernel and what was the > precise problem? 2.6.27, those defines were redefined (by the subsequent include of mce.h) > ATM I could only imagine that the block above is > included before original mce.h, right? Then adding an explicit include > here should cure the problem. > Yes. -- error compiling committee.c: too many arguments to function