From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Huff Subject: Re: [PATCH] [KVM_Autotest] Fix to allow for "=" in the "value" of a config parameter. Date: Tue, 26 May 2009 11:39:02 -0400 Message-ID: <4A1C0D16.6090402@redhat.com> References: <825827984.224981242990310267.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <4A193A37.6030305@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: unlisted-recipients:; (no To-header on input) Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48134 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563AbZEZPjk (ORCPT ); Tue, 26 May 2009 11:39:40 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4QFdgWa031357 for ; Tue, 26 May 2009 11:39:42 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4QFdf2f012435 for ; Tue, 26 May 2009 11:39:42 -0400 Received: from sunset.usersys.redhat.com (dhcp231-89.rdu.redhat.com [10.11.231.89]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4QFdfhu012400 for ; Tue, 26 May 2009 11:39:41 -0400 In-Reply-To: <4A193A37.6030305@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Michael Goldish wrote: >> This makes sense, thanks. >> >> One thing though -- I don't know if it's even worth mentioning -- we >> always try to put a single space after a comma (I think the Python >> style guide recommends that but I'm not sure). Generally we try to >> follow the guide (http://www.python.org/dev/peps/pep-0008/) and as far >> as I know Autotest follows it too. >> > > Strongly agree, Python's syntax allows us to write very pretty code, it > makes sense to preserve this. > Thanks for the advice new patch to follow shortly.... -D