From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gleb Natapov <gleb@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH v2] qemu-kvm: x86: Refactor persistent CPU state
Date: Wed, 27 May 2009 12:48:26 +0300 [thread overview]
Message-ID: <4A1D0C6A.2070009@redhat.com> (raw)
In-Reply-To: <4A1A3F15.30809@web.de>
Jan Kiszka wrote:
>> Why are you using uint64_t? It would be more natural to use ffsll and
>> the natural type of the bitmap vector.
>>
>
> Better don't ask how I interpreted the ffs doc.
>
It's a misdesigned API anyway.
>
> + if (version_id >= 9) {
> + qemu_get_sbe32s(f, &pending_irq);
> + memset(&env->interrupt_bitmap, 0, sizeof(env->interrupt_bitmap));
> + if (pending_irq >= 0) {
> + env->interrupt_bitmap[pending_irq / 64] |= 1 << (pending_irq % 64);
>
(uint64_t)1 so we don't lose the upper word.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-27 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 20:55 [RFC][PATCH] qemu-kvm: x86: Refactor persistent CPU state Jan Kiszka
2009-05-24 12:13 ` Avi Kivity
2009-05-25 6:47 ` [PATCH v2] " Jan Kiszka
2009-05-27 9:48 ` Avi Kivity [this message]
2009-05-27 10:16 ` [PATCH v3] " Jan Kiszka
2009-05-27 11:03 ` Avi Kivity
2009-05-27 11:39 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1D0C6A.2070009@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox