Re: [PATCH] kvm-kmod: Add MSR_K7_HWCR and MSR_K8_SYSCFG compat definition

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Jaswinder Singh Rajput wrote:
> Hello Jan,
> 
> On Tue, 2009-05-26 at 23:01 +0200, Jan Kiszka wrote:
>> Reposted as joint patch as there is no MSR_K7 in your next queue.
>>
>> -------->
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>>  x86/external-module-compat.h |    8 ++++++++
>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h
>> index 445c7a1..0e26743 100644
>> --- a/x86/external-module-compat.h
>> +++ b/x86/external-module-compat.h
>> @@ -496,6 +496,14 @@ struct kvm_desc_ptr {
>>  #define MSR_IA32_TSC                    0x00000010
>>  #endif
>>  
>> +#ifndef MSR_K7_HWCR
>> +#define MSR_K7_HWCR                     0xc0010015
>> +#endif
>> +
>> +#ifndef MSR_K8_SYSCFG
>> +#define MSR_K8_SYSCFG                   0xc0010010
>> +#endif
>> +
> 
> It will look more beautiful if we arrange MSR addresses in some order
> (say increasing order) :
> 
> +#ifndef MSR_K8_SYSCFG
> +#define MSR_K8_SYSCFG                   0xc0010010
> +#endif
> +
> +#ifndef MSR_K7_HWCR
> +#define MSR_K7_HWCR                     0xc0010015
> +#endif
> +

Well, I just used a different sorting key: K7 vs. K8...

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]