From: Avi Kivity <avi@redhat.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Jan Kiszka <jan.kiszka@web.de>, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm-kmod: Add MSR_K7_HWCR and MSR_K8_SYSCFG compat definition
Date: Wed, 27 May 2009 14:12:21 +0300 [thread overview]
Message-ID: <4A1D2015.4040408@redhat.com> (raw)
In-Reply-To: <1243422377.6863.4.camel@localhost.localdomain>
Jaswinder Singh Rajput wrote:
> On Wed, 2009-05-27 at 12:05 +0200, Jan Kiszka wrote:
>
>> Jaswinder Singh Rajput wrote:
>>
>>> It will look more beautiful if we arrange MSR addresses in some order
>>> (say increasing order) :
>>>
>>> +#ifndef MSR_K8_SYSCFG
>>> +#define MSR_K8_SYSCFG 0xc0010010
>>> +#endif
>>> +
>>> +#ifndef MSR_K7_HWCR
>>> +#define MSR_K7_HWCR 0xc0010015
>>> +#endif
>>> +
>>>
>> Well, I just used a different sorting key: K7 vs. K8...
>>
>>
>
> sorting with K7, K8 are not very helpful, on the other hand if we sort
> with MSR address it will be helpful in :
> 1. searching of MSR
> 2. adding new MSR
> 3. avoid duplicate MSR
> 4. of course looks beautiful ;-)
>
Let's not get carried away.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-05-27 11:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 11:52 [PATCH 0/8] kvm-kmod: Compat fixes & enhancements Jan Kiszka
2009-05-26 11:52 ` [PATCH 3/8] kvm-kmod: Include relayfs_fs.h on pre-2.6.17 kernels Jan Kiszka
2009-05-26 11:52 ` [PATCH 2/8] kvm-kmod: Include asm/uaccess.h on pre-2.6.18 kernels Jan Kiszka
2009-05-26 11:52 ` [PATCH 1/8] kvm-kmod: Allow to override sync source Jan Kiszka
2009-05-26 11:52 ` [PATCH 8/8] kvm-kmod: x86: Add MCE compat defines Jan Kiszka
2009-05-26 12:08 ` Avi Kivity
2009-05-26 12:43 ` Jan Kiszka
2009-05-26 12:59 ` Avi Kivity
2009-05-26 13:47 ` [PATCH v2] " Jan Kiszka
2009-05-26 13:51 ` Avi Kivity
2009-05-26 11:52 ` [PATCH 5/8] kvm-kmod: Fix msi_enabled patching Jan Kiszka
2009-05-26 11:52 ` [PATCH 4/8] kvm-kmod: Provide flush_work compat wrapper Jan Kiszka
2009-05-26 11:52 ` [PATCH 7/8] kvm-kmod: x86: Add MSR_IA32_TSC compat define Jan Kiszka
2009-05-26 12:29 ` Jaswinder Singh Rajput
2009-05-26 12:36 ` Jan Kiszka
2009-05-26 12:42 ` Avi Kivity
2009-05-26 12:53 ` Jan Kiszka
2009-05-26 12:58 ` Avi Kivity
2009-05-26 12:48 ` Jaswinder Singh Rajput
2009-05-26 11:52 ` [PATCH 6/8] kvm-kmod: Add eventfd.c to patch list Jan Kiszka
2009-05-26 12:01 ` [PATCH 0/8] kvm-kmod: Compat fixes & enhancements Avi Kivity
2009-05-26 12:54 ` [PATCH] kvm-kmod: x86: Add MSR_K8_SYSCFG compat define Jan Kiszka
2009-05-26 21:01 ` [PATCH] kvm-kmod: Add MSR_K7_HWCR and MSR_K8_SYSCFG compat definition Jan Kiszka
2009-05-27 9:27 ` Avi Kivity
2009-05-27 9:55 ` Jaswinder Singh Rajput
2009-05-27 10:05 ` Jan Kiszka
2009-05-27 11:06 ` Jaswinder Singh Rajput
2009-05-27 11:12 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1D2015.4040408@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jaswinder@kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox