From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm-kmod: Add MSR_K7_HWCR and MSR_K8_SYSCFG compat definition Date: Wed, 27 May 2009 14:12:21 +0300 Message-ID: <4A1D2015.4040408@redhat.com> References: <20090526115251.3362.54734.stgit@mchn012c.ww002.siemens.net> <4A1BE668.7090106@siemens.com> <4A1C58A5.1030700@web.de> <1243418126.3109.18.camel@localhost.localdomain> <4A1D1074.9060503@web.de> <1243422377.6863.4.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , kvm@vger.kernel.org To: Jaswinder Singh Rajput Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59401 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761189AbZE0LNO (ORCPT ); Wed, 27 May 2009 07:13:14 -0400 In-Reply-To: <1243422377.6863.4.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Jaswinder Singh Rajput wrote: > On Wed, 2009-05-27 at 12:05 +0200, Jan Kiszka wrote: > >> Jaswinder Singh Rajput wrote: >> >>> It will look more beautiful if we arrange MSR addresses in some order >>> (say increasing order) : >>> >>> +#ifndef MSR_K8_SYSCFG >>> +#define MSR_K8_SYSCFG 0xc0010010 >>> +#endif >>> + >>> +#ifndef MSR_K7_HWCR >>> +#define MSR_K7_HWCR 0xc0010015 >>> +#endif >>> + >>> >> Well, I just used a different sorting key: K7 vs. K8... >> >> > > sorting with K7, K8 are not very helpful, on the other hand if we sort > with MSR address it will be helpful in : > 1. searching of MSR > 2. adding new MSR > 3. avoid duplicate MSR > 4. of course looks beautiful ;-) > Let's not get carried away. -- error compiling committee.c: too many arguments to function