From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Huff Subject: Re: kvm_autotest: dynamically load tests Date: Wed, 27 May 2009 08:14:08 -0400 Message-ID: <4A1D2E90.4030602@redhat.com> References: <1240955328-23358-1-git-send-email-dhuff@redhat.com> <4A1D281A.7040401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Uri Lublin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53947 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbZE0MOp (ORCPT ); Wed, 27 May 2009 08:14:45 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4RCEm2l031617 for ; Wed, 27 May 2009 08:14:48 -0400 In-Reply-To: <4A1D281A.7040401@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Uri Lublin wrote: > Hi David, > > I'm not sure this patch-set makes development much easier, as it only > saves adding one line (entry) in test_routines table, but is less > flexible (e.g. force file-name and function-name of test routines). > > Moving the test to a separate kvm_tests directory can be done without > dynamic load of the tests. > > I don't have strong feelings about it though. > > What others think ? > > Thanks, > Uri. Uri, Thanks for the feedback, Lucas and I had a brief discussion about this last week so I just wanted to repost what I already had just as a starting point for a discussion on this topic, I know my patches are rough. Our thinking is that it would be nice to be able to drop new tests in to a kvm_test dir, modify the config file, and not have to "update" the kvm_auottest or autotest binarys. However I would also like to hear others opinions on this... -D