From mboxrd@z Thu Jan 1 00:00:00 1970 From: john cooper Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3 Date: Fri, 29 May 2009 00:04:40 -0400 Message-ID: <4A1F5ED8.40402@redhat.com> References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de> <20090527075409.GA7926@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: rusty@rustcorp.com.au, qemu-devel@nongnu.org, KVM list , john.cooper@redhat.com, Rusty Russell To: Christoph Hellwig Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42386 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbZE2EHy (ORCPT ); Fri, 29 May 2009 00:07:54 -0400 In-Reply-To: <20090527075409.GA7926@lst.de> Sender: kvm-owner@vger.kernel.org List-ID: Christoph Hellwig wrote: > On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote: >> /* >> * IDE-compatible identify ioctl. >> * >> * Currenlyt only returns the serial number and leaves all other fields >> * zero. >> */ > > Btw, thinking about it the rest of the information in the ioctl should > probably be filled up with faked data, similar to how we do it for > the ide emulation inside qemu. Agreed. I've done so to the extent it makes sense in the case of the more generic fields. A fair amount of the identify information being generated by hw/ide.c appears obsoleted. -john -- john.cooper@redhat.com