From mboxrd@z Thu Jan  1 00:00:00 1970
From: john cooper <john.cooper@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk,
 V3
Date: Fri, 29 May 2009 00:05:04 -0400
Message-ID: <4A1F5EF0.5090702@redhat.com>
References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de> <200905272223.27614.rusty@rustcorp.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Christoph Hellwig <hch@lst.de>, KVM list <kvm@vger.kernel.org>,
	qemu-devel@nongnu.org, john.cooper@redhat.com
To: Rusty Russell <rusty@rustcorp.com.au>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:42387 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750798AbZE2EHy (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 29 May 2009 00:07:54 -0400
In-Reply-To: <200905272223.27614.rusty@rustcorp.com.au>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


>> +	if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL)))
>> +		rv = -ENOMEM;
> 
> Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes?

Yes I caught that bug in the rework as well.

> What's this *for* BTW?

Sorry -- I assumed you were on either list.
Please see patch to follow.

-john

-- 
john.cooper@redhat.com