From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: No disable_irq for MSI/MSI-X interrupt on device assignment Date: Sun, 31 May 2009 12:48:51 +0300 Message-ID: <4A225283.3030306@redhat.com> References: <1241060322-25807-1-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49632 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753575AbZEaJsx (ORCPT ); Sun, 31 May 2009 05:48:53 -0400 In-Reply-To: <1241060322-25807-1-git-send-email-sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Disable interrupt at interrupt handler and enable it when guest ack is for > the level triggered interrupt, to prevent reinjected interrupt. MSI/MSI-X don't > need it. > > One possible problem is multiply same vector interrupt injected between irq > handler and scheduled work handler would be merged as one for MSI/MSI-X. > But AFAIK, the drivers handle it well. > > The patch fixed the oplin card performance issue(MSI-X performance is half of > MSI/INTx). > Applied, thanks. -- error compiling committee.c: too many arguments to function