From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v4] qemu-kvm: Make PC speaker emulation aware of in-kernel PIT Date: Sun, 31 May 2009 12:10:18 +0200 Message-ID: <4A22578A.3070701@web.de> References: <4A092506.9090308@web.de> <4A09F0F9.7080804@web.de> <4A0C8259.4010701@web.de> <20090515221422.GB12643@amt.cnet> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig452E7654F65CAB4329E5877C" Cc: kvm-devel To: Marcelo Tosatti , Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:60065 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910AbZEaKKW (ORCPT ); Sun, 31 May 2009 06:10:22 -0400 In-Reply-To: <20090515221422.GB12643@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig452E7654F65CAB4329E5877C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Marcelo Tosatti wrote: > On Thu, May 14, 2009 at 10:43:05PM +0200, Jan Kiszka wrote: >> When using the in-kernel PIT the speaker emulation has to synchronize >> the PIT state with KVM. Enhance the existing speaker sound device and >> allow it to take over port 0x61 by using KVM_CREATE_PIT2 where >> available. This unbreaks -soundhw pcspk in KVM mode. >> >> Changes in v4: >> - preserve full PIT state across read-modify-write >> - update kvm.h >> >> Changes in v3: >> - re-added incorrectly dropped kvm_enabled checks >> >> Changes in v2: >> - rebased over qemu-kvm and KVM_CREATE_PIT2 >> - refactored hooks in pcspk >> >> Signed-off-by: Jan Kiszka >=20 > Jan, >=20 > You always attempt to use KVM_CREATE_PIT2, so say on migration if the > destination does not support the new ioctl you fallback to in-kernel > dummy naturally. Seems the right thing to do. >=20 > Would be nice to avoid sprinkling KVM details inside hw/pcspk.c though > but that is another problem. Does this remark prevent merging the patch ATM? I do not see another way how to make the pcspk aware of the in-kernel PIT, given that the speaker is naturally coupled to PIT channel 2. >=20 > Looks good (and v3 kernel patch). >=20 Jan --------------enig452E7654F65CAB4329E5877C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEUEARECAAYFAkoiV48ACgkQniDOoMHTA+ljJQCfftlkb5yfM7CqKNvjkPcmEJw6 AQUAl3ZXmAHJIw7kK2szVLSw1pLo20Y= =fX6r -----END PGP SIGNATURE----- --------------enig452E7654F65CAB4329E5877C--