public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: KVM mailing list <kvm@vger.kernel.org>
Subject: Re: [PATCH + RFC] Cascading option --with-kvm-trace to qemu configure script
Date: Sun, 31 May 2009 14:21:12 +0300	[thread overview]
Message-ID: <4A226828.5050202@redhat.com> (raw)
In-Reply-To: <1243384814.2858.55.camel@localhost.localdomain>

Lucas Meneghel Rodrigues wrote:
> We've found a build issue on release tarballs: if we take a recent
> release tarball, build it using the usual sequence
>
> ./configure
> make
> make install
>
> The modules generated can't be loaded due to unresolved symbols related
> to kvm trace. While fixing the problem, we noticed that is not possible
> to pass the --with-kvm-trace option to the main qemu configure script.
>
> This patch makes it possible to cascade --with-kvm-trace option from the
> qemu toplevel configure script to the KVM kernel configure script. It is
> our understanding that this cascading is desirable, however we are not
> completely sure about it, hence we are asking for comments on this
> change.
>   

You are right, it's a bug and your fix below is correct.  Applied.

-- 
error compiling committee.c: too many arguments to function


      reply	other threads:[~2009-05-31 11:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-27  0:40 [PATCH + RFC] Cascading option --with-kvm-trace to qemu configure script Lucas Meneghel Rodrigues
2009-05-31 11:21 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A226828.5050202@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox