From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH + RFC] Cascading option --with-kvm-trace to qemu configure script Date: Sun, 31 May 2009 14:21:12 +0300 Message-ID: <4A226828.5050202@redhat.com> References: <1243384814.2858.55.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM mailing list To: Lucas Meneghel Rodrigues Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45789 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbZEaLVN (ORCPT ); Sun, 31 May 2009 07:21:13 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4VBLFBZ010614 for ; Sun, 31 May 2009 07:21:15 -0400 In-Reply-To: <1243384814.2858.55.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Lucas Meneghel Rodrigues wrote: > We've found a build issue on release tarballs: if we take a recent > release tarball, build it using the usual sequence > > ./configure > make > make install > > The modules generated can't be loaded due to unresolved symbols related > to kvm trace. While fixing the problem, we noticed that is not possible > to pass the --with-kvm-trace option to the main qemu configure script. > > This patch makes it possible to cascade --with-kvm-trace option from the > qemu toplevel configure script to the KVM kernel configure script. It is > our understanding that this cascading is desirable, however we are not > completely sure about it, hence we are asking for comments on this > change. > You are right, it's a bug and your fix below is correct. Applied. -- error compiling committee.c: too many arguments to function