From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Burns Subject: Re: [PATCH][KVM-AUTOTEST] Have Custom install chdir to test.bindir Date: Mon, 01 Jun 2009 14:39:18 -0400 Message-ID: <4A242056.2050908@redhat.com> References: <1242851931-8492-1-git-send-email-mburns@redhat.com> <4A195ED5.6030001@redhat.com> Reply-To: mburns@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, dhuff@redhat.com, ulublin@redhat.com To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45502 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbZFASjS (ORCPT ); Mon, 1 Jun 2009 14:39:18 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n51IdLGp010311 for ; Mon, 1 Jun 2009 14:39:21 -0400 In-Reply-To: <4A195ED5.6030001@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Mike Burns wrote: >> If you are using custom install and load_modules=yes, then autotest >> needs to >> change to the test.bindir so that it looks for kernel modules in the >> right >> place. >> >> Signed-off-by: Mike Burns >> --- >> client/tests/kvm_runtest_2/kvm_install.py | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/client/tests/kvm_runtest_2/kvm_install.py >> b/client/tests/kvm_runtest_2/kvm_install.py >> index d1aceb2..ebd8b7d 100755 >> --- a/client/tests/kvm_runtest_2/kvm_install.py >> +++ b/client/tests/kvm_runtest_2/kvm_install.py >> @@ -79,6 +79,7 @@ def run_kvm_install(test, params, env): >> >> # install from custom script >> elif install_mode == "custom": >> + os.chdir(test.bindir) >> install_script = params.get("install_script") >> script = os.path.join(test.bindir,install_script) >> if not install_script: >> > > Don't you need to chdir back afterwards? > > Opportunity for a with statement. > No, the custom install option essentially is replacing the call to __install_kvm which does a chdir and doesn't ever revert back to the original directory. Either this is handled somewhere outside of the kvm_install.py script or it is not necessary. Mike