From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/3] KVM: Cache pdptrs
Date: Tue, 02 Jun 2009 12:09:17 +0300
Message-ID: <4A24EC3D.9020507@redhat.com>
References: <1243862524-22120-1-git-send-email-avi@redhat.com> <1243862524-22120-4-git-send-email-avi@redhat.com> <20090602090428.GN4062@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	Sheng Yang <sheng@linux.intel.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:35810 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751921AbZFBJJT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 2 Jun 2009 05:09:19 -0400
In-Reply-To: <20090602090428.GN4062@amd.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Joerg Roedel wrote:
> On Mon, Jun 01, 2009 at 04:22:03PM +0300, Avi Kivity wrote:
>   
>> +static void svm_cache_reg(struct kvm_vcpu *vcpu, enum kvm_reg reg)
>> +{
>> +	switch (reg) {
>> +	case VCPU_EXREG_PDPTR:
>> +		BUG_ON(!npt_enabled);
>> +		load_pdptrs(vcpu, vcpu->arch.cr3);
>> +		break;
>> +	default:
>> +		BUG();
>> +	}
>> +}
>>     
>
> Don't we need to check for the return value of load_pdptrs() here and inject
> a #GP it it fails?
>   

We're after some random exit, the guest won't be expecting a #GP in some 
random instruction.

The only options are ignore and triple fault.

>> +
>>  static void svm_set_vintr(struct vcpu_svm *svm)
>>  {
>>  	svm->vmcb->control.intercept |= 1ULL << INTERCEPT_VINTR;
>> @@ -2286,12 +2298,6 @@ static int handle_exit(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
>>  		}
>>  		vcpu->arch.cr0 = svm->vmcb->save.cr0;
>>  		vcpu->arch.cr3 = svm->vmcb->save.cr3;
>> -		if (is_paging(vcpu) && is_pae(vcpu) && !is_long_mode(vcpu)) {
>> -			if (!load_pdptrs(vcpu, vcpu->arch.cr3)) {
>> -				kvm_inject_gp(vcpu, 0);
>> -				return 1;
>> -			}
>> -		}
>>     
>
> ... as done here.

That's a bug... luckily no guests trash their PDPTs after loading CR3.

I guess I should fix in a separate patch to avoid mixing a bugfix with a 
feature.

-- 
error compiling committee.c: too many arguments to function