From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM: VMX: Simplify pdptr and cr3 management Date: Tue, 02 Jun 2009 13:16:14 +0300 Message-ID: <4A24FBEE.60409@redhat.com> References: <1243862524-22120-1-git-send-email-avi@redhat.com> <200906021730.38414.sheng@linux.intel.com> <4A24F4FF.70104@redhat.com> <200906021756.50038.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Joerg Roedel To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43031 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756255AbZFBKQQ (ORCPT ); Tue, 2 Jun 2009 06:16:16 -0400 In-Reply-To: <200906021756.50038.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > On Tuesday 02 June 2009 17:46:39 Avi Kivity wrote: > >> Sheng Yang wrote: >> >>> No, no, not with the new code. For CPU can load pdptrs if EPT enabled >>> with PAE from VM exit, there should not be necessary load it explicitly. >>> So I estimate the ept_load_pdptr() in exit handler, and put it in CR0 >>> handling. Just tried to optimize load-pdptr according to the spec, but >>> not got the desired result... >>> >>> So I am trying to find the failure reason... >>> >> so from your point of view, the patches are okay? >> > > Yes. But we should can optimize it more by avoiding most of PDPTR loading, > according to the spec. > Patch 3 makes reloading a very rare event. It only happens on pae mode changes or if userspace sets cr3. -- error compiling committee.c: too many arguments to function