From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH] qemu-kvm: Flush icache after dma operations for ia64 Date: Tue, 02 Jun 2009 12:56:54 +0200 Message-ID: <4A250576.1030702@sgi.com> References: <706158FABBBA044BAD4FE898A02E4BC236B1935F@pdsmsx503.ccr.corp.intel.com> <4A0807DC.6080109@redhat.com> <4A1A8015.8080908@redhat.com> <4A1A9951.5030408@sgi.com> <4A1BE0E2.3090306@redhat.com> <706158FABBBA044BAD4FE898A02E4BC201BD66196B@pdsmsx503.ccr.corp.intel.com> <4A238735.1050006@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , "kvm@vger.kernel.org" , "kvm-ia64@vger.kernel.org" , Hollis Blanchard To: Avi Kivity Return-path: Received: from relay3.sgi.com ([192.48.156.57]:52683 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755717AbZFBK45 (ORCPT ); Tue, 2 Jun 2009 06:56:57 -0400 In-Reply-To: <4A238735.1050006@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Zhang, Xiantao wrote: >> Fine to me. But seems the change in qemu_iovec_from_buffer is lost in >> this patch or that change is also not unnecessary ? > > I think the fixed unmap handles that case. Can you test to make sure? > Avi and I went through the code and verified that it was all covered by the unmap case. It was pretty messy to come to the conclusion, which is why I tried to document it in the code and the patch description. Cheers, Jes