From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM: VMX: Simplify pdptr and cr3 management Date: Tue, 02 Jun 2009 14:44:49 +0300 Message-ID: <4A2510B1.6070900@redhat.com> References: <1243862524-22120-1-git-send-email-avi@redhat.com> <200906021756.50038.sheng@linux.intel.com> <4A24FBEE.60409@redhat.com> <200906021931.08737.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Joerg Roedel To: Sheng Yang Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42923 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760784AbZFBLov (ORCPT ); Tue, 2 Jun 2009 07:44:51 -0400 In-Reply-To: <200906021931.08737.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Sheng Yang wrote: > Yes, you are right. Quite beautiful. :) > Thanks :) It's basically a continuation of RIP/RSP caching. I plan to continue it for cr0/cr3. > Sorry for misunderstood the meaning of "on demand" without looking at the > patch carefully... > > Looks fine now. Thanks! > > BTW: one extra blank line above function kvm_pdptr_read() in patch 3. ;) > Will fix. -- error compiling committee.c: too many arguments to function