From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] clean up cpu hotplug code Date: Tue, 02 Jun 2009 15:01:00 +0300 Message-ID: <4A25147C.9010509@redhat.com> References: <1243921342-17704-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55211 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbZFBMBB (ORCPT ); Tue, 2 Jun 2009 08:01:01 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n52C13oL024229 for ; Tue, 2 Jun 2009 08:01:03 -0400 In-Reply-To: <1243921342-17704-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > There's nothing kvm specific in get_cpu function. Remove it from > kvm ifdef. Buy us a cleaner code, and may help us with any attempt > of integrating this on the future. > > Signed-off-by: Glauber Costa > --- > hw/acpi.c | 12 +++--------- > 1 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/hw/acpi.c b/hw/acpi.c > index f4062ac..7f23e4e 100644 > --- a/hw/acpi.c > +++ b/hw/acpi.c > @@ -770,9 +770,7 @@ static void disable_processor(struct gpe_regs *g, int cpu) > g->cpus_sts[cpu/8] &= ~(1 << (cpu%8)); > } > > -#if defined(TARGET_I386) || defined(TARGET_X86_64) > -#ifdef USE_KVM > -static CPUState *qemu_kvm_cpu_env(int index) > +static CPUState *qemu_get_cpu_env(int index) > { > CPUState *penv; > > @@ -786,18 +784,14 @@ static CPUState *qemu_kvm_cpu_env(int index) > > return NULL; > } > -#endif > Want this cause an undefined function warning on non-x86 targets? If you send two identical patches, please version them and note the changes. -- error compiling committee.c: too many arguments to function