Re: [PATCH v7 1/2] qemu-kvm: add irqfd support

[Gregory Haskins <ghaskins@novell.com>]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Avi Kivity wrote:
> Gregory Haskins wrote:
>> irqfd lets you create an eventfd based file-desriptor to inject
>> interrupts
>> to a kvm guest.  We associate one gsi per fd for fine-grained routing.
>>
>>   
>
> Sorry, getting to userspace a little late in the game.
Np.. I need to re-work this for the POLLHUP patch I am about to push anyway.

>
>> @@ -34,6 +34,7 @@
>>  #include <string.h>
>>  #include <errno.h>
>>  #include <sys/ioctl.h>
>> +#include <sys/eventfd.h>
>>   
>
> This only made it in 2.6.22.  So it needs a ./configure -time check
> for existence.

I could also just put this within the #ifdef KVM_CAP_IRQFD?


>
>> +int kvm_create_irqfd(kvm_context_t kvm, int gsi, int flags)
>> +{
>> +    return -ENOENT;
>> +}
>> +
>> +int kvm_destroy_irqfd(kvm_context_t kvm, int fd, int flags)
>> +{
>> +    return -ENOENT;
>> +}
>>   
>
> -ENOSYS is more traditional.
>
Ack.

-Greg




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]