From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gregory Haskins <ghaskins@novell.com>
Subject: Re: [PATCH v7 1/2] qemu-kvm: add irqfd support
Date: Tue, 02 Jun 2009 10:54:41 -0400
Message-ID: <4A253D31.6010507@novell.com>
References: <20090512183059.26356.94857.stgit@dev.haskins.net> <20090512183226.26356.46296.stgit@dev.haskins.net> <4A227818.8030809@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigDD64966BE6DF1E6D9050574D"
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from victor.provo.novell.com ([137.65.250.26]:48893 "EHLO
	victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753308AbZFBOyx (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 2 Jun 2009 10:54:53 -0400
In-Reply-To: <4A227818.8030809@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDD64966BE6DF1E6D9050574D
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Avi Kivity wrote:
> Gregory Haskins wrote:
>> irqfd lets you create an eventfd based file-desriptor to inject
>> interrupts
>> to a kvm guest.  We associate one gsi per fd for fine-grained routing.=

>>
>>  =20
>
> Sorry, getting to userspace a little late in the game.
Np.. I need to re-work this for the POLLHUP patch I am about to push anyw=
ay.

>
>> @@ -34,6 +34,7 @@
>>  #include <string.h>
>>  #include <errno.h>
>>  #include <sys/ioctl.h>
>> +#include <sys/eventfd.h>
>>  =20
>
> This only made it in 2.6.22.  So it needs a ./configure -time check
> for existence.

I could also just put this within the #ifdef KVM_CAP_IRQFD?


>
>> +int kvm_create_irqfd(kvm_context_t kvm, int gsi, int flags)
>> +{
>> +    return -ENOENT;
>> +}
>> +
>> +int kvm_destroy_irqfd(kvm_context_t kvm, int fd, int flags)
>> +{
>> +    return -ENOENT;
>> +}
>>  =20
>
> -ENOSYS is more traditional.
>
Ack.

-Greg




--------------enigDD64966BE6DF1E6D9050574D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkolPTUACgkQlOSOBdgZUxnxEACfSxRafB4HWErvqTy+a9WL6Bjs
GSkAnR/f97DrYqYk6sU7QDUxcy2/PVzz
=AV1z
-----END PGP SIGNATURE-----

--------------enigDD64966BE6DF1E6D9050574D--