public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gregory Haskins <ghaskins@novell.com>
To: unlisted-recipients:; (no To-header on input)
Cc: kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH v8] qemu-kvm: add irqfd support
Date: Tue, 02 Jun 2009 11:48:17 -0400	[thread overview]
Message-ID: <4A2549C1.70703@novell.com> (raw)
In-Reply-To: <20090602154233.30489.81627.stgit@dev.haskins.net>

[-- Attachment #1: Type: text/plain, Size: 3333 bytes --]

Gregory Haskins wrote:
> irqfd lets you create an eventfd based file-desriptor to inject interrupts
> to a kvm guest.  We associate one gsi per fd for fine-grained routing.
>
> [note: this is meant to work in conjunction with the POLLHUP version of
>  irqfd, which has not yet been accepted into kvm.git]
>
> [ Changelog:
>
>     v8:
>         *) removed deassign() verb in favor of POLLHUP support on close()
>         *) only include sys/eventfd.h if CAP_IRQFD is defined to properly
>            support older kernels
>         *) s/ENOENT/ENOSYS
> ] 
>   

Hmm..it would appear I already released a 'v8' in the past. :(

In any case, this is the latest version to consider

-Greg

> Signed-off-by: Gregory Haskins <ghaskins@novell.com>
> ---
>
>  kvm/libkvm/libkvm.c |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  kvm/libkvm/libkvm.h |   14 ++++++++++++++
>  2 files changed, 63 insertions(+), 0 deletions(-)
>
> diff --git a/kvm/libkvm/libkvm.c b/kvm/libkvm/libkvm.c
> index ba0a5d1..10cb2ac 100644
> --- a/kvm/libkvm/libkvm.c
> +++ b/kvm/libkvm/libkvm.c
> @@ -1444,3 +1444,52 @@ int kvm_assign_set_msix_entry(kvm_context_t kvm,
>          return ret;
>  }
>  #endif
> +
> +#ifdef KVM_CAP_IRQFD
> +
> +#include <sys/eventfd.h>
> +
> +static int _kvm_irqfd(kvm_context_t kvm, int fd, int gsi, int flags)
> +{
> +	int r;
> +	struct kvm_irqfd data = {
> +		.fd    = fd,
> +		.gsi   = gsi,
> +		.flags = flags,
> +	};
> +
> +	r = ioctl(kvm->vm_fd, KVM_IRQFD, &data);
> +	if (r == -1)
> +		r = -errno;
> +	return r;
> +}
> +
> +int kvm_irqfd(kvm_context_t kvm, int gsi, int flags)
> +{
> +	int r;
> +	int fd;
> +
> +	if (!kvm_check_extension(kvm, KVM_CAP_IRQFD))
> +		return -ENOENT;
> +
> +	fd = eventfd(0, 0);
> +	if (fd < 0)
> +		return -errno;
> +
> +	r = _kvm_irqfd(kvm, fd, gsi, 0);
> +	if (r < 0) {
> +		close(fd);
> +		return -errno;
> +	}
> +
> +	return fd;
> +}
> +
> +#else /* KVM_CAP_IRQFD */
> +
> +int kvm_irqfd(kvm_context_t kvm, int gsi, int flags)
> +{
> +	return -ENOSYS;
> +}
> +
> +#endif /* KVM_CAP_IRQFD */
> diff --git a/kvm/libkvm/libkvm.h b/kvm/libkvm/libkvm.h
> index 4821a1e..aca8ed6 100644
> --- a/kvm/libkvm/libkvm.h
> +++ b/kvm/libkvm/libkvm.h
> @@ -856,6 +856,20 @@ int kvm_commit_irq_routes(kvm_context_t kvm);
>   */
>  int kvm_get_irq_route_gsi(kvm_context_t kvm);
>  
> +/*!
> + * \brief Create a file descriptor for injecting interrupts
> + *
> + * Creates an eventfd based file-descriptor that maps to a specific GSI
> + * in the guest.  eventfd compliant signaling (write() from userspace, or
> + * eventfd_signal() from kernelspace) will cause the GSI to inject
> + * itself into the guest at the next available window.
> + *
> + * \param kvm Pointer to the current kvm_context
> + * \param gsi GSI to assign to this fd
> + * \param flags reserved, must be zero
> + */
> +int kvm_irqfd(kvm_context_t kvm, int gsi, int flags);
> +
>  #ifdef KVM_CAP_DEVICE_MSIX
>  int kvm_assign_set_msix_nr(kvm_context_t kvm,
>  			   struct kvm_assigned_msix_nr *msix_nr);
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]

  reply	other threads:[~2009-06-02 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 15:45 [PATCH v8] qemu-kvm: add irqfd support Gregory Haskins
2009-06-02 15:48 ` Gregory Haskins [this message]
2009-06-04 10:06 ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2009-05-14 17:02 Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2549C1.70703@novell.com \
    --to=ghaskins@novell.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox