From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Haskins Subject: Re: [KVM-RFC PATCH 0/2] irqfd: use POLLHUP notification for close() Date: Tue, 02 Jun 2009 12:14:15 -0400 Message-ID: <4A254FD7.5090302@novell.com> References: <20090602151135.29746.91320.stgit@dev.haskins.net> <20090602160434.GA6827@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig358DB68B82E720B672CCCD90" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com, davidel@xmailserver.org, paulmck@linux.vnet.ibm.com To: "Michael S. Tsirkin" Return-path: Received: from victor.provo.novell.com ([137.65.250.26]:36031 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbZFBQOW (ORCPT ); Tue, 2 Jun 2009 12:14:22 -0400 In-Reply-To: <20090602160434.GA6827@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig358DB68B82E720B672CCCD90 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Michael S. Tsirkin wrote: > On Tue, Jun 02, 2009 at 11:15:28AM -0400, Gregory Haskins wrote: > =20 >> (Applies to kvm.git/master:25deed73) >> >> Please see the header for 2/2 for a description. This patch series ha= s >> been fully tested and appears to be working correctly. I have it as a= n RFC >> for now because it needs Davide's official submission/SOB for patch 1/= 2, and >> it should get some eyeballs/acks on my SRCU usage before going in. >> >> I will submit the updated irqfd userspace which eschews the deassign()= verb >> since we can now just use the close(fd) method alone. I will also add= ress >> the userspace review comments from Avi. >> =20 > > > We are not killing the deassign though, do we? > =20 Yes, it is not needed any more now that we have proper release-notification from eventfd. > It's good to have that option e.g. for when we pass > the fd to another process. > =20 Passing the fd to another app should up the underlying file reference count. If the producer app wants to "deassign" it simply calls close(fd) (as opposed to today where it calls DEASSIGN+close), but the reference count will allow the consuming app to leave the eventfd's file open. Or am I misunderstanding you? -Greg --------------enig358DB68B82E720B672CCCD90 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkolT9sACgkQlOSOBdgZUxkQTwCfUtobQKbApxMzQhQIdQSFmHfl sYYAoIUtqLM3+w8LyRNr4MDaLjKBT4Kn =dd/g -----END PGP SIGNATURE----- --------------enig358DB68B82E720B672CCCD90--