From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/4] always halt non-bsp cpu. Date: Tue, 02 Jun 2009 22:35:47 +0200 Message-ID: <4A258D23.9080106@web.de> References: <1243971470-31676-1-git-send-email-glommer@redhat.com> <1243971470-31676-2-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig85633C32B10CD5A3D57BC58F" Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:54822 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbZFBUfw (ORCPT ); Tue, 2 Jun 2009 16:35:52 -0400 In-Reply-To: <1243971470-31676-2-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig85633C32B10CD5A3D57BC58F Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: > This is not kvm specific, and should do fine in plain qemu This is fine with plain qemu already. The problem, IIUC, is that in-kernel kvm irqchip does not have a chance to remove the halted state again. Did you test the effect of this patch on that scenario? What makes it safe to be removed now? >=20 > Signed-off-by: Glauber Costa > --- > hw/apic.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/apic.c b/hw/apic.c > index 86aa6b6..2eddba0 100644 > --- a/hw/apic.c > +++ b/hw/apic.c > @@ -467,8 +467,7 @@ static void apic_init_ipi(APICState *s) > =20 > cpu_reset(s->cpu_env); > =20 > - if (!(s->apicbase & MSR_IA32_APICBASE_BSP) && > - (!kvm_enabled() || !qemu_kvm_irqchip_in_kernel())) > + if (!(s->apicbase & MSR_IA32_APICBASE_BSP)) > s->cpu_env->halted =3D 1; > =20 > if (kvm_enabled() && !qemu_kvm_irqchip_in_kernel()) Jan --------------enig85633C32B10CD5A3D57BC58F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoljSkACgkQniDOoMHTA+nTHQCfZtGH++ayr9lE9TN2vc9azCOc bSkAnidtsvMOnwZGElmJoImY/tLEvH70 =wQCP -----END PGP SIGNATURE----- --------------enig85633C32B10CD5A3D57BC58F--