From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Re: [PATCH] qemu: virtio save/load bindings Date: Wed, 03 Jun 2009 13:31:32 +0300 Message-ID: <4A265104.6060700@redhat.com> References: <20090525133405.GA6166@redhat.com> <4A1BA998.8040803@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , Carsten Otte , kvm@vger.kernel.org, Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl , Christian Borntraeger , Paul Brook To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38487 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbZFCKeB (ORCPT ); Wed, 3 Jun 2009 06:34:01 -0400 In-Reply-To: <4A1BA998.8040803@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> Implement bindings for virtio save/load. Use them in virtio pci. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> >> Is anyone working to fill in load/save bindings so that saving virtio >> devices works? Here's a trivial patch to do this (this one is on top >> of my >> MSI-X patchset). >> Comments? >> >> hw/virtio-pci.c | 49 >> ++++++++++++++++++++++++++++++++++++++++++++++++- >> hw/virtio.c | 31 ++++++++++++++----------------- >> hw/virtio.h | 4 ++++ >> 3 files changed, 66 insertions(+), 18 deletions(-) >> >> static void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev, >> diff --git a/hw/virtio.c b/hw/virtio.c >> index 63ffcff..b773dff 100644 >> --- a/hw/virtio.c >> +++ b/hw/virtio.c >> @@ -568,9 +568,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f) >> { >> int i; >> >> - /* FIXME: load/save binding. */ >> - //pci_device_save(&vdev->pci_dev, f); >> - //msix_save(&vdev->pci_dev, f); >> > > qdev regressed save/restore? What else is broken right now from the > qdev commit? > > I'm beginning to think committing in the state it was in was a > mistake. Paul, can you put together a TODO so that we know all of the > things that have regressed so we can get things back into shape? > virtio is still broken. Anthony, are you planning to commit this patch? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.