From: Avi Kivity <avi@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: ying.huang@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2/2] KVM: Add VT-x machine check support
Date: Thu, 04 Jun 2009 16:10:14 +0300 [thread overview]
Message-ID: <4A27C7B6.6030709@redhat.com> (raw)
In-Reply-To: <20090604130107.GA1065@one.firstfloor.org>
Andi Kleen wrote:
>> vmcs access work because we have a preempt notifier called when we are
>> scheduled in, and will execute vmclear/vmptrld as necessary. Look at
>> kvm_preempt_ops in virt/kvm_main.c.
>>
>
> I see. So we need to move that check earlier. Do you have a preference
> where it should be?
>
There's no good place as it breaks the nice exit handler table. You
could put it in vmx_complete_interrupts() next to NMI handling.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-06-04 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 11:12 [PATCH] [1/2] x86: MCE: Define MCE_VECTOR Andi Kleen
2009-06-04 11:12 ` [PATCH] [2/2] KVM: Add VT-x machine check support Andi Kleen
2009-06-04 11:48 ` Avi Kivity
2009-06-04 12:51 ` Andi Kleen
2009-06-04 12:49 ` Avi Kivity
2009-06-04 13:01 ` Andi Kleen
2009-06-04 13:10 ` Avi Kivity [this message]
2009-06-04 13:20 ` Andi Kleen
2009-06-04 13:49 ` Avi Kivity
2009-06-04 14:07 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A27C7B6.6030709@redhat.com \
--to=avi@redhat.com \
--cc=andi@firstfloor.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox