From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] use KVMState, as upstream do
Date: Sun, 07 Jun 2009 12:21:53 +0300 [thread overview]
Message-ID: <4A2B86B1.2040502@redhat.com> (raw)
In-Reply-To: <1244139783-15787-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> This is a pretty mechanical change. To make code look
> closer to upstream qemu, I'm renaming kvm_context_t to
> KVMState. Mid term goal here is to start sharing code
> whereas possible.
>
Doesn't apply.
Also, it's a little fishy. We now have two KVMState types, but they're
pretty different.
What we could do is embed a kvm_context_t variable in the real KVMState,
and start using that. Then, we could, function by function, use the
upstream KVMState functionality and remove the corresponding
kvm_context_t functionality.
> Avi, please apply, or I'll send you a video of myself
> dancing naked.
>
The list has a size limit, so don't attach a huge video. Post a URL
instead.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-06-07 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 18:23 [PATCH] use KVMState, as upstream do Glauber Costa
[not found] ` <20090604192329.GD18757@redhat.com>
[not found] ` <20090604193319.GG30777@poweredge.glommer>
2009-06-04 20:00 ` Gleb Natapov
2009-06-04 20:10 ` Glauber Costa
2009-06-04 20:09 ` Gleb Natapov
2009-06-04 20:18 ` Glauber Costa
2009-06-04 20:17 ` Gleb Natapov
2009-06-07 9:21 ` Avi Kivity [this message]
2009-06-07 10:08 ` Jan Kiszka
2009-06-07 10:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2B86B1.2040502@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox