From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] use KVMState, as upstream do Date: Sun, 07 Jun 2009 12:21:53 +0300 Message-ID: <4A2B86B1.2040502@redhat.com> References: <1244139783-15787-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37855 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbZFGJWG (ORCPT ); Sun, 7 Jun 2009 05:22:06 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n579M8cC004196 for ; Sun, 7 Jun 2009 05:22:08 -0400 In-Reply-To: <1244139783-15787-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > This is a pretty mechanical change. To make code look > closer to upstream qemu, I'm renaming kvm_context_t to > KVMState. Mid term goal here is to start sharing code > whereas possible. > Doesn't apply. Also, it's a little fishy. We now have two KVMState types, but they're pretty different. What we could do is embed a kvm_context_t variable in the real KVMState, and start using that. Then, we could, function by function, use the upstream KVMState functionality and remove the corresponding kvm_context_t functionality. > Avi, please apply, or I'll send you a video of myself > dancing naked. > The list has a size limit, so don't attach a huge video. Post a URL instead. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.