From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] use KVMState, as upstream do Date: Sun, 07 Jun 2009 12:08:05 +0200 Message-ID: <4A2B9185.9090601@web.de> References: <1244139783-15787-1-git-send-email-glommer@redhat.com> <4A2B86B1.2040502@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD6AB965343C70EAC06BD0C50" Cc: Glauber Costa , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:57373 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbZFGKIR (ORCPT ); Sun, 7 Jun 2009 06:08:17 -0400 In-Reply-To: <4A2B86B1.2040502@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD6AB965343C70EAC06BD0C50 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Glauber Costa wrote: >> This is a pretty mechanical change. To make code look >> closer to upstream qemu, I'm renaming kvm_context_t to >> KVMState. Mid term goal here is to start sharing code >> whereas possible. >> =20 >=20 > Doesn't apply. >=20 > Also, it's a little fishy. We now have two KVMState types, but they're= > pretty different. >=20 > What we could do is embed a kvm_context_t variable in the real KVMState= , > and start using that. Then, we could, function by function, use the > upstream KVMState functionality and remove the corresponding > kvm_context_t functionality. That would be great and was also what I had vaguely in mind. Likely there are already fields that can be used from KVMState (fd and vmfd?). >=20 >> Avi, please apply, or I'll send you a video of myself >> dancing naked. >> =20 >=20 > The list has a size limit, so don't attach a huge video. Post a URL > instead. >=20 But only after 22:00 - in case underages are reading. Jan --------------enigD6AB965343C70EAC06BD0C50 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkorkZIACgkQniDOoMHTA+kHPwCfTenKidc3V6HiB/4Ds+3xdMA6 OQkAn2M074j2KrUCHM0dUXD4g2M+1+C/ =CbFo -----END PGP SIGNATURE----- --------------enigD6AB965343C70EAC06BD0C50--