From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] fix include paths when the kernel source and build directory are different Date: Mon, 08 Jun 2009 10:31:16 +0200 Message-ID: <4A2CCC54.4050800@siemens.com> References: <20090603125840.GA16209@dupont.ts-a> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Avi Kivity To: James Pike Return-path: Received: from gecko.sbs.de ([194.138.37.40]:18690 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754132AbZFHIbe (ORCPT ); Mon, 8 Jun 2009 04:31:34 -0400 In-Reply-To: <20090603125840.GA16209@dupont.ts-a> Sender: kvm-owner@vger.kernel.org List-ID: James Pike wrote: > Use correct architecture includes when kernel source and build directory > are different. > Signed-off-by: James Pike > > diff --git a/Makefile b/Makefile > index 95e4c81..ad08c45 100644 > --- a/Makefile > +++ b/Makefile > @@ -27,8 +27,9 @@ all:: prerequisite > # include header priority 1) $LINUX 2) $KERNELDIR 3) include-compat > $(MAKE) -C $(KERNELDIR) M=`pwd` \ > LINUXINCLUDE="-I`pwd`/include -Iinclude \ > - $(if $(KERNELSOURCEDIR),-Iinclude2 -I$(KERNELSOURCEDIR)/include) \ > - -Iarch/${ARCH_DIR}/include -I`pwd`/include-compat \ > + $(if $(KERNELSOURCEDIR),\ > + -Iinclude2 -I$(KERNELSOURCEDIR)/include -I$(KERNELSOURCEDIR)/arch/${ARCH_DIR}/include, \ > + -Iarch/${ARCH_DIR}/include) -I`pwd`/include-compat \ > -include include/linux/autoconf.h \ > -include `pwd`/$(ARCH_DIR)/external-module-compat.h $(module_defines)" \ > "$$@" Just confirmed: Required when building against home-brewed kernels with split source/binaries. Avi, please merge. Acked-by: Jan Kiszka Jan