From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] fix include paths when the kernel source and build	directory
 are different
Date: Mon, 08 Jun 2009 11:42:05 +0300
Message-ID: <4A2CCEDD.6000006@redhat.com>
References: <20090603125840.GA16209@dupont.ts-a>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: James Pike <james@chilon.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:39052 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751506AbZFHImH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 8 Jun 2009 04:42:07 -0400
In-Reply-To: <20090603125840.GA16209@dupont.ts-a>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

James Pike wrote:
> Use correct architecture includes when kernel source and build directory
> are different.
> Signed-off-by: James Pike <james@chilon.net>
>   
> --- a/Makefile
> +++ b/Makefile
> @@ -27,8 +27,9 @@ all:: prerequisite
>  #	include header priority 1) $LINUX 2) $KERNELDIR 3) include-compat
>  	$(MAKE) -C $(KERNELDIR) M=`pwd` \
>  		LINUXINCLUDE="-I`pwd`/include -Iinclude \
> -		$(if $(KERNELSOURCEDIR),-Iinclude2 -I$(KERNELSOURCEDIR)/include) \
> -		-Iarch/${ARCH_DIR}/include -I`pwd`/include-compat \
> +		$(if $(KERNELSOURCEDIR),\
> +			-Iinclude2 -I$(KERNELSOURCEDIR)/include -I$(KERNELSOURCEDIR)/arch/${ARCH_DIR}/include, \
> +			-Iarch/${ARCH_DIR}/include) -I`pwd`/include-compat \
>  		-include include/linux/autoconf.h \
>  		-include `pwd`/$(ARCH_DIR)/external-module-compat.h $(module_defines)" \
>  		"$$@"
>   

This removes -Iarch/${ARCH_DIR}/include when KERNELSOURCEDIR is not 
defined.  What is the reason for this change?

-- 
error compiling committee.c: too many arguments to function