From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] fix detection of kernel source directory Date: Mon, 08 Jun 2009 11:49:17 +0300 Message-ID: <4A2CD08D.1080700@redhat.com> References: <20090603125954.GA16220@dupont.ts-a> <4A2CCC69.2030709@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: James Pike , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47375 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060AbZFHItS (ORCPT ); Mon, 8 Jun 2009 04:49:18 -0400 In-Reply-To: <4A2CCC69.2030709@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > James Pike wrote: > >> Fix detection of kernel source directory when it is different to build >> directory. >> Signed-off-by: James Pike >> >> diff --git a/configure b/configure >> index e01ba98..c3b7a5f 100755 >> --- a/configure >> +++ b/configure >> @@ -91,7 +91,7 @@ arch=${arch%%-*} >> >> # see if we have split build and source directories >> if [ -d "$kerneldir/include2" ]; then >> - kernelsourcedir=${kerneldir%/*}/source >> + kernelsourcedir=`readlink -f $kerneldir/source` >> fi >> >> if [ -n "$no_uname" -a "$want_module" ]; then >> > > So far I can't reproduce any problem that the above could fix, but maybe > Avi sees why we need it and that it doesn't regress elsewhere. > > I don't. James, what triggered this? -- error compiling committee.c: too many arguments to function