From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] sipi and init: move common code Date: Mon, 08 Jun 2009 12:08:17 +0300 Message-ID: <4A2CD501.1020007@redhat.com> References: <1244063970-13913-1-git-send-email-glommer@redhat.com> <1244063970-13913-2-git-send-email-glommer@redhat.com> <1244063970-13913-3-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41436 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbZFHJIS (ORCPT ); Mon, 8 Jun 2009 05:08:18 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5898KsQ023024 for ; Mon, 8 Jun 2009 05:08:20 -0400 In-Reply-To: <1244063970-13913-3-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > provide functions to query and reset the state of sipi and > init in cpu's apic. This way we can move the kvm specific functions > out of the apic path. > > The new functions and data members are kvm specific. Please update their names to reflect that. 'sipi_needed' would be really confusing for someone reading the code from a tcg perspective (it's confusing even from a kvm perspective, but that's our problem and can be addressed later). -- error compiling committee.c: too many arguments to function