[patch 3/4] KVM: MMU audit: nontrapping ptes in nonleaf level

Marcelo Tosatti
2009-06-02T21:44:34Z

[-- Attachment #1: mmu-audit-3 --]
[-- Type: text/plain, Size: 849 bytes --]

update_pte sets nonleaf sptes as notrap, so either it or the audit code
is broken.

Choose the audit code.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: kvm/arch/x86/kvm/mmu.c
===================================================================
--- kvm.orig/arch/x86/kvm/mmu.c
+++ kvm/arch/x86/kvm/mmu.c
@@ -3081,12 +3081,7 @@ static void audit_mappings_page(struct k

va = canonicalize(va);
if (level > 1) {
- if (ent == shadow_notrap_nonpresent_pte)
- printk(KERN_ERR "audit: (%s) nontrapping pte"
- " in nonleaf level: levels %d gva %lx"
- " level %d pte %llx\n", audit_msg,
- vcpu->arch.mmu.root_level, va, level, ent);
- else
+ if (is_shadow_present_pte(ent))
audit_mappings_page(vcpu, ent, va, level - 1);
} else {
gpa_t gpa = vcpu->arch.mmu.gva_to_gpa(vcpu, va);

--