From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 4/4] KVM: MMU audit: audit_mappings tweaks
Date: Mon, 08 Jun 2009 12:29:55 +0300
Message-ID: <4A2CDA13.4080200@redhat.com>
References: <20090602213655.640083007@localhost.localdomain> <20090602214227.199310641@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: sheng@linux.intel.com, kvm@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:56846 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752747AbZFHJ35 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 8 Jun 2009 05:29:57 -0400
In-Reply-To: <20090602214227.199310641@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
> @@ -3256,7 +3261,8 @@ static void kvm_mmu_audit(struct kvm_vcp
>  	audit_msg = msg;
>  	audit_rmap(vcpu);
>  	audit_write_protection(vcpu);
> -	audit_mappings(vcpu);
> +	if (strcmp("pre pte write", audit_msg))
> +		audit_mappings(vcpu);
>  	audit_writable_sptes_have_rmaps(vcpu);
>  	dbg = olddbg;
>  }
>   

strcmp() doesn't return a truth value, please add != 0.

-- 
error compiling committee.c: too many arguments to function