From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org, Carsten Otte <cotte@de.ibm.com>,
Hollis Blanchard <hollisb@us.ibm.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [PATCH 0/4] decouple vcpu index from apic id
Date: Mon, 08 Jun 2009 14:25:10 +0300 [thread overview]
Message-ID: <4A2CF516.7080206@redhat.com> (raw)
In-Reply-To: <1244453578-29857-1-git-send-email-gleb@redhat.com>
Gleb Natapov wrote:
> Currently vcpu_id is used as an index into vcpus array and as apic id
> on x86. This is incorrect since apic ids not have to be continuous
> (they can also encode cpu hierarchy information) and may have values
> bigger then vcpu array in case of x2apic. This series removes use of
> vcpu_id as vcpus array index. Each architecture may use it how it sees
> fit. x86 uses it as apic id.
>
>
Apart from my minor comments, this looks good, but I'd like to get acks
from arch maintainers to avoid surprises.
Xiantao, does setting the bsp id make sense for ia64?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-06-08 11:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 9:32 [PATCH 0/4] decouple vcpu index from apic id Gleb Natapov
2009-06-08 9:32 ` [PATCH 1/4] Introduce kvm_vcpu_is_bsp() function Gleb Natapov
2009-06-08 11:20 ` Avi Kivity
2009-06-08 16:53 ` Hollis Blanchard
2009-06-08 16:57 ` Avi Kivity
2009-06-09 1:00 ` Zhang, Xiantao
2009-06-09 3:35 ` Avi Kivity
2009-06-08 9:32 ` [PATCH 2/4] Use pointer to vcpu instead of vcpu_id in timer code Gleb Natapov
2009-06-08 9:32 ` [PATCH 3/4] Break dependency between vcpu index in vcpus array and vcpu_id Gleb Natapov
2009-06-08 11:23 ` Avi Kivity
2009-06-08 9:32 ` [PATCH 4/4] Use macro to iterate over vcpus Gleb Natapov
2009-06-08 11:25 ` Avi Kivity [this message]
2009-06-09 2:30 ` [PATCH 0/4] decouple vcpu index from apic id Zhang, Xiantao
2009-06-09 5:26 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2CF516.7080206@redhat.com \
--to=avi@redhat.com \
--cc=cotte@de.ibm.com \
--cc=gleb@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).