From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] Advertise X2APIC support. Date: Mon, 08 Jun 2009 15:13:33 +0300 Message-ID: <4A2D006D.5090101@redhat.com> References: <1242927475-6140-1-git-send-email-gleb@redhat.com> <1242927475-6140-3-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42743 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754595AbZFHMNd (ORCPT ); Mon, 8 Jun 2009 08:13:33 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58CDauM028144 for ; Mon, 8 Jun 2009 08:13:36 -0400 In-Reply-To: <1242927475-6140-3-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > > #define MSR_MTRRcap 0xfe > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 23efcf4..170c3f7 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -148,7 +148,7 @@ static x86_def_t x86_defs[] = { > CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | > /* this feature is needed for Solaris and isn't fully implemented */ > CPUID_PSE36, > - .ext_features = CPUID_EXT_SSE3, > + .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_X2APIC, > .ext2_features = (PPRO_FEATURES & 0x0183F3FF) | > CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX | > CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT, > @@ -199,7 +199,8 @@ static x86_def_t x86_defs[] = { > /* The original CPU also implements these ext features: > CPUID_EXT_DTES64, CPUID_EXT_DSCPL, CPUID_EXT_VMX, CPUID_EXT_EST, > CPUID_EXT_TM2, CPUID_EXT_CX16, CPUID_EXT_XTPR, CPUID_EXT_PDCM */ > - .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_SSSE3, > + .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_SSSE3 | > + CPUID_EXT_X2APIC, > .ext2_features = CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX, > /* Missing: .ext3_features = CPUID_EXT3_LAHF_LM */ > .xlevel = 0x80000008, > x2apic is not present on most cpus, so it should not be available by default. Users can enable it with -cpu +x2apic -- error compiling committee.c: too many arguments to function