From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] sipi and init: move common code Date: Mon, 08 Jun 2009 18:48:38 +0300 Message-ID: <4A2D32D6.9040304@redhat.com> References: <1244063970-13913-1-git-send-email-glommer@redhat.com> <1244063970-13913-2-git-send-email-glommer@redhat.com> <1244063970-13913-3-git-send-email-glommer@redhat.com> <4A2CD501.1020007@redhat.com> <20090608155253.GA11966@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46619 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752941AbZFHPsi (ORCPT ); Mon, 8 Jun 2009 11:48:38 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58Fmfra014954 for ; Mon, 8 Jun 2009 11:48:41 -0400 In-Reply-To: <20090608155253.GA11966@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > On Mon, Jun 08, 2009 at 12:08:17PM +0300, Avi Kivity wrote: > >> Glauber Costa wrote: >> >>> provide functions to query and reset the state of sipi and >>> init in cpu's apic. This way we can move the kvm specific functions >>> out of the apic path. >>> >>> >>> >> The new functions and data members are kvm specific. Please update >> their names to reflect that. 'sipi_needed' would be really confusing >> for someone reading the code from a tcg perspective (it's confusing even >> from a kvm perspective, but that's our problem and can be addressed >> later). >> > The idea of such series is exactly to write it in a way that is _not_ > kvm specific, although kvm is the only user. So, I may change the > name if you prefer, but I would not like to introduce any "kvm" string > on it. To do that, we might as well stick with what we have. > Well, sipi_needed is certainly kvm specific, if you look at its usage. I don't see how anything else could use it. -- error compiling committee.c: too many arguments to function